Maarrk/tio
1
0
Fork 0
mirror of https://github.com/tio/tio.git synced 2026-05-01 23:07:58 +02:00
Code Issues Projects Releases 1 Packages Wiki Activity Actions

Check return values of sscanf()

Browse source 
Failing to check that a call to 'sscanf' actually writes to an output
variable can lead to unexpected behavior at reading time.
This commit is contained in:
Mingjie Shen 2024-03-23 22:26:43 -04:00
parent ed4ac0c797
commit adf2f20374
2 changed files with 10 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/options.c
View file

@ -163,7 +163,11 @@ void line_pulse_duration_option_parse(const char *arg)
{ {
char keyname[11]; char keyname[11];
unsigned int value; unsigned int value;
sscanf(token, "%10[^=]=%d", keyname, &value);
if (sscanf(token, "%10[^=]=%d", keyname, &value) != 2)
{
token_found = false;
}
if (!strcmp(keyname, "DTR")) if (!strcmp(keyname, "DTR"))
{ {

6
src/rs485.c
View file

@ -57,7 +57,11 @@ void rs485_parse_config(const char *arg)
{ {
char keyname[31]; char keyname[31];
unsigned int value; unsigned int value;
sscanf(token, "%30[^=]=%d", keyname, &value);
if (sscanf(token, "%30[^=]=%d", keyname, &value) != 2)
{
token_found = false;
}
if (!strcmp(keyname, "RTS_ON_SEND")) if (!strcmp(keyname, "RTS_ON_SEND"))
{ {